Fix: Handle C++ exceptions in Windows Graphics Capture API#1178
Closed
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Closed
Fix: Handle C++ exceptions in Windows Graphics Capture API#1178seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CAP-DESKTOP-M5. The issue was that: GraphicsCapture API failure throws unhandled C++ exception across FFI boundary, corrupting Rust runtime and causing fatal crash.
CreateForMonitorandCreateForWindowcalls incatch_unwindto handle C++ exceptions thrown by the Graphics Capture API on Windows 10 build 18363.This fix was generated by Seer in Sentry, triggered by Richie. 👁️ Run ID: 1917985
Not quite right? Click here to continue debugging with Seer.