web: Improve upload user image UI #1224
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| "use client"; | ||
|
|
||
| import { Button } from "@cap/ui"; | ||
| import { faImage } from "@fortawesome/free-solid-svg-icons"; | ||
| import { FontAwesomeIcon } from "@fortawesome/react-fontawesome"; | ||
| import clsx from "clsx"; | ||
| import Image from "next/image"; | ||
| import { useEffect, useRef, useState } from "react"; | ||
| import { toast } from "sonner"; | ||
|
|
||
| interface ProfileImageProps { | ||
| initialPreviewUrl?: string | null; | ||
| onChange?: (file: File | null) => void; | ||
| onRemove?: () => void; | ||
| disabled?: boolean; | ||
| isUploading?: boolean; | ||
| isRemoving?: boolean; | ||
| } | ||
|
|
||
| export function ProfileImage({ | ||
| initialPreviewUrl, | ||
| onChange, | ||
| onRemove, | ||
| disabled = false, | ||
| isUploading = false, | ||
| isRemoving = false, | ||
| }: ProfileImageProps) { | ||
| const [previewUrl, setPreviewUrl] = useState<string | null>( | ||
| initialPreviewUrl || null, | ||
| ); | ||
| const fileInputRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| // Reset isRemoving when the parent confirms the operation completed | ||
| useEffect(() => { | ||
| if (initialPreviewUrl !== undefined) { | ||
| setPreviewUrl(initialPreviewUrl); | ||
| } | ||
| }, [initialPreviewUrl]); | ||
|
ameer2468 marked this conversation as resolved.
|
||
|
|
||
| const handleFileChange = () => { | ||
| const file = fileInputRef.current?.files?.[0]; | ||
| if (!file) return; | ||
| const sizeLimit = 1024 * 1024 * 1; | ||
| if (file.size > sizeLimit) { | ||
| toast.error("File size must be 1MB or less"); | ||
| return; | ||
| } | ||
| if (file && file.size <= sizeLimit) { | ||
| const objectUrl = URL.createObjectURL(file); | ||
| setPreviewUrl(objectUrl); | ||
| onChange?.(file); | ||
| } | ||
| }; | ||
|
ameer2468 marked this conversation as resolved.
ameer2468 marked this conversation as resolved.
|
||
|
|
||
| const handleRemove = () => { | ||
| setPreviewUrl(null); | ||
| if (fileInputRef.current) { | ||
| fileInputRef.current.value = ""; | ||
| } | ||
| onRemove?.(); | ||
| }; | ||
|
Comment on lines
+57
to
+63
Contributor
There was a problem hiding this comment. Memory leak: Object URL not revoked on remove. When removing an image, if Apply this diff: const handleRemove = () => {
+ // Revoke local object URL before removing
+ if (previewUrl && previewUrl.startsWith("blob:")) {
+ URL.revokeObjectURL(previewUrl);
+ }
setPreviewUrl(null);
if (fileInputRef.current) {
fileInputRef.current.value = "";
}
onRemove?.();
};🤖 Prompt for AI Agents |
||
|
|
||
| const handleUploadClick = () => { | ||
| if (!disabled && !isUploading && !isRemoving) { | ||
| fileInputRef.current?.click(); | ||
| } | ||
| }; | ||
|
|
||
| const isLoading = isUploading || isRemoving; | ||
|
|
||
| return ( | ||
| <div className="rounded-xl border border-dashed bg-gray-2 h-fit border-gray-4"> | ||
| <div className="flex gap-5 p-5"> | ||
| <div | ||
| className={clsx( | ||
| "flex justify-center items-center rounded-full border size-14 bg-gray-3 border-gray-6", | ||
| previewUrl ? "border-solid" : "border-dashed", | ||
| )} | ||
| > | ||
| {previewUrl ? ( | ||
| <Image | ||
| src={previewUrl} | ||
| alt="Profile Image" | ||
| width={56} | ||
| className="object-cover rounded-full size-14" | ||
| height={56} | ||
| /> | ||
| ) : ( | ||
| <FontAwesomeIcon icon={faImage} className="size-4 text-gray-9" /> | ||
| )} | ||
| </div> | ||
| <input | ||
| type="file" | ||
| className="hidden h-0" | ||
| accept="image/jpeg, image/jpg, image/png, image/svg+xml" | ||
| ref={fileInputRef} | ||
| onChange={handleFileChange} | ||
| disabled={disabled || isLoading} | ||
| /> | ||
| <div className="space-y-3"> | ||
| <div className="flex gap-2"> | ||
| {!isRemoving && ( | ||
| <Button | ||
| type="button" | ||
| variant="gray" | ||
| disabled={disabled || isLoading} | ||
| size="xs" | ||
| onClick={handleUploadClick} | ||
| spinner={isUploading} | ||
| > | ||
| {isUploading ? "Uploading..." : "Upload Image"} | ||
| </Button> | ||
| )} | ||
| {(previewUrl || isRemoving) && ( | ||
| <Button | ||
| type="button" | ||
| variant="outline" | ||
| disabled={disabled || isLoading} | ||
| size="xs" | ||
| onClick={handleRemove} | ||
| spinner={isRemoving} | ||
| > | ||
| {isRemoving ? "Removing image..." : "Remove"} | ||
| </Button> | ||
| )} | ||
| </div> | ||
| <p className="text-xs text-gray-10">Recommended size: 120x120</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.