Skip to content

recording: Improve error handling for hardware encoder failures on Windows #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 4 commits into from
Oct 23, 2025
Merged

recording: Improve error handling for hardware encoder failures on Windows #1254

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9df524d
recording: Improve error handling for hardware encoder failures on Wi…
seer-by-sentry[bot] Oct 20, 2025
9b59611
allow returning errors from spawn_thread
Brendonovich Oct 23, 2025
c799d86
some fixes
Brendonovich Oct 23, 2025
b2c4f20
fix build
Brendonovich Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/recording/src/output_pipeline/win.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ impl Muxer for WindowsMuxer {
either::Left((mut encoder, mut muxer)) => {
trace!("Running native encoder");
let mut first_timestamp = None;
encoder
if let Err(e) = encoder
.run(
Arc::new(AtomicBool::default()),
|| {
Expand All @@ -157,7 +157,13 @@ impl Muxer for WindowsMuxer {
Ok(())
},
)
.unwrap();
{
error!(
"Hardware encoder failed with error: {} (code: {:?}). This may be due to hardware limitations or driver issues.",
e.message(),
e.code()
);
}
}
either::Right(mut encoder) => {
while let Ok(Some((frame, time))) = video_rx.recv() {
Expand Down
Loading