Add icon and purpose #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commenter25
force-pushed
the
icon-inclusion
branch
from
ca17c99 to
65e4173
Compare
Author
|
@Xerasin @CapsAdmin Sorry to be a bother, any odds of this being merged? Anything I could change to get it merged? No rush, just a nudge in case this was missed ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a spawnmenu icon, and points the upload script to that. Also added a purpose description, and enabled the weapon selection popup that shows it. Besides the expected effects, it's worth noting both of these are also useful for custom stores, such as in Jazztronauts. As such, I'm willing to remove the popup if that's undesired, but I would recommend keeping the description.
I remastered the original icon with a frame directly extracted from downloading the YouTube video it came from. It's about as good as you can make a frame from a uploaded to YouTube in 480p in 2012 that has massive border around it and needs to be exactly 512x512. The file size is also reduced from 256kb to 50kb, which is a nice bonus. I also made sure it's a baseline 4:2:0 JPEG, as gmpublish requires.