[EAG-829] Fix offset issues in several elements. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcarranza-carecloud
force-pushed
the
feature/EAG-829
branch
from
ff857d4 to
d4c9d7c
Compare
**Ticket:** https://jira.carecloud.com/browse/EAG-829 **Reviewers:** @jnorris-carecloud, @jleyba-carecloud **Changes:** - Fix issues with some elements' offsets with the editor was not in the coords `{x: 0, y: 0}`
rcarranza-carecloud
force-pushed
the
feature/EAG-829
branch
from
d4c9d7c to
56a8793
Compare
nbroda-carecloud
approved these changes
Apr 4, 2018
the-graph/the-graph-library.js
Outdated
|
|
||
| // The offset should be applied only to clientX/Y if layerX/Y don't exist. | ||
| // TODO: Check if there is another way of doing this without using layerX/Y. | ||
| // The use of clientX/Y work in most cases except when there are margin/padding in parent elements |
There was a problem hiding this comment.
s/work/works
s/there are/there is
s/affect/affects
jnorris-carecloud
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.carecloud.com/browse/EAG-829
Reviewers: @jnorris-carecloud, @jleyba-carecloud
Changes:
{x: 0, y: 0}Notes: