-
Notifications
You must be signed in to change notification settings - Fork 0
[CMAT-49] fix: 채용 공고 목록 조회 API 반환 데이터 추가 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4d5012f
[CMAT-49] fix: PageResponseDTO를 빌더 패턴을 사용하여 생성하도록 수정한다
momuzzi f02efdd
[CMAT-49] fix: 채용 공고 목록 조회 시 전체 페이지 수, JobName를 추가 반환하도록 수정한다
momuzzi 7e2fef2
[CMAT-49] fix: 프로필에서 job 변경 시 GptAnswer 데이터를 해당 job으로 업데이트하도록 수정한다
momuzzi 2342523
[CMAT-49] fix: 조건을 추가한다
momuzzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 0 additions & 26 deletions
26
src/main/java/UMC/career_mate/domain/recruit/dto/response/RecommendRecruitDTO.java
This file was deleted.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
src/main/java/UMC/career_mate/domain/recruit/dto/response/RecommendRecruitsDTO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package UMC.career_mate.domain.recruit.dto.response; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
| import lombok.Builder; | ||
|
|
||
| @Builder | ||
| public record RecommendRecruitsDTO( | ||
| String jobName, | ||
| List<RecruitThumbNailInfoDTO> recruitThumbNailInfoDTOList | ||
| ) { | ||
|
|
||
| @Builder | ||
| public record RecruitThumbNailInfoDTO( | ||
| Long recruitId, | ||
| String companyName, | ||
| String title, | ||
| String deadLine, | ||
| boolean isScraped, | ||
|
|
||
| /** | ||
| * TODO: 아래로는 (필터링, 정렬) 잘 되는지 확인용 데이터, 나중에 삭제 예정 | ||
| */ | ||
| Integer experienceLevelCode, // 경력 코드 : 0(경력무관), 1(신입), 2(경력), 3(신입/경력) | ||
| Integer experienceLevelMin, // 경력 년수 최소 값 | ||
| Integer experienceLevelMax, // 경력 년수 최대 값 | ||
| String experienceLevelName, | ||
| Integer educationLevelCode, // 학력 코드 0(학력무관), 1(고등학교졸업), 2(대학졸업(2,3년)), 3(대학졸업(4년)), 4(석사졸업), 5(박사졸업) 등 | ||
| String educationLevelName, | ||
| LocalDateTime postingDate | ||
| ) { | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
src/main/java/UMC/career_mate/global/common/PageResponseDTO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
PageResponseDTO 생성 시 totalPages 필드 누락
PageResponseDTO에 새로 추가된 totalPages 필드가 설정되지 않았습니다. 클라이언트의 페이지네이션 구현을 위해 이 정보가 필요할 수 있습니다.
다음과 같이 수정을 제안합니다:
return PageResponseDTO.<List<ContentScrapResponseDTO>>builder() .page(page) .hasNext(scraps.hasNext()) + .totalPages(scraps.getTotalPages()) .result(contentList) .build();📝 Committable suggestion