Skip to content

Conversation

@KSLEE19
Copy link
Contributor

@KSLEE19 KSLEE19 commented Feb 5, 2025

#️⃣ 요약 설명

📝 작업 내용

코드의 흐름이나 중요한 부분을 작성해주세요.

Member member = memberRepository.findById(memberId).orElseThrow(
                () -> new GeneralException(CommonErrorCode.NOT_FOUND_BY_MEMBER_ID)
        );

        member.delete();

코드에 대한 간단한 설명 부탁드립니다.
soft delete로 되어있기 때문에 탈퇴 회원의 deletedAt 필드에 값을 넣는 방식입니다.

동작 확인

기능을 실행했을 때 정상 동작하는지 여부를 확인하고 사진을 올려주세요

ex) 테스트 코드 작성후 성공 사진
ex) swagger 사진

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

Summary by CodeRabbit

  • 새로운 기능
    • 회원 프로필 삭제 기능 도입: 이제 사용자가 자신의 프로필을 삭제할 수 있으며, 삭제 요청 후 확인 메시지를 수신합니다.
    • 삭제된 회원 목록 조회 기능 추가: 관리자가 삭제된 회원 정보를 한눈에 확인할 수 있습니다.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이 PR은 회원 관리 도메인에 프로필 삭제 관련 기능을 추가합니다. MemberController에 프로필 삭제를 위한 deleteProfile 엔드포인트를 도입하고, MemberRepository에 삭제된 회원을 조회할 수 있는 findDeleteMembers 메서드를 추가하였습니다. 또한, MemberService에는 회원 프로필 삭제를 수행하는 deleteProfile과 삭제된 회원 목록을 가져오는 getDeleteMemberList 메서드가 추가되었으며, createProfile 메서드의 코드 포맷도 수정되었습니다.

Changes

파일 변경 요약
src/.../controller/MemberController.java deleteProfile 엔드포인트 추가 및 createProfile 메서드 포맷 수정
src/.../repository/MemberRepository.java 삭제된 회원 조회를 위한 findDeleteMembers() 메서드 추가
src/.../service/MemberService.java 프로필 삭제를 위한 deleteProfile와 삭제 회원 목록 조회용 getDeleteMemberList 메서드 추가

Sequence Diagram(s)

sequenceDiagram
    participant C as MemberController
    participant S as MemberService
    participant R as MemberRepository
    participant M as Member

    C->>S: deleteProfile(member)
    S->>R: 회원 조회(memberId)
    alt 회원 존재함
        S->>M: delete() 호출
        M-->>S: 삭제 완료
        S-->>C: ApiResponse 반환 (성공 메시지 포함)
    else 회원 미존재
        S-->>C: GeneralException 발생
    end
Loading

Possibly related PRs

Suggested reviewers

  • veronees
  • jpark0506
  • jjeongdong

Poem

나는 토끼, 코드 숲을 누비며 달리네,
새 기능의 향연 속에 마음 춤추네,
삭제의 길을 따라 발자국 남기고,
프로필 사라진 자리에 웃음 피우네,
🐇 오늘도 코드의 들판을 깡충깡충!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d74d9b and ec38aba.

📒 Files selected for processing (3)
  • src/main/java/UMC/career_mate/domain/member/controller/MemberController.java (2 hunks)
  • src/main/java/UMC/career_mate/domain/member/repository/MemberRepository.java (2 hunks)
  • src/main/java/UMC/career_mate/domain/member/service/MemberService.java (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KSLEE19 KSLEE19 added the feat 기능 추가 label Feb 5, 2025
@KSLEE19 KSLEE19 self-assigned this Feb 5, 2025
@KSLEE19 KSLEE19 merged commit 2fd4e61 into develop Feb 5, 2025
1 check was pending
@KSLEE19 KSLEE19 deleted the feature/CMAT-52 branch February 5, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants