[CMAT-60] fix: 스크랩한 컨텐츠 조회에서 현재 직무와 같은 컨텐츠만 조회되도록 수정 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough이번 PR은 Changes
Sequence Diagram(s)sequenceDiagram
participant Client as 클라이언트
participant Service as ContentScrapService
participant Repository as ContentScrapRepository
participant DB as 데이터베이스
Client->>Service: getScrapContents(member, page, size) 호출
Service->>Service: jobId 검증 (null인 경우 예외 발생)
Service->>Repository: findByMemberAndJobId(member, jobId, pageable) 호출
Repository->>DB: JPQL 쿼리 실행
DB-->>Repository: Page<ContentScrap> 결과 반환
Repository-->>Service: 결과 전달
Service-->>Client: 변환된 ContentScrapResponseDTO 반환
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jpark0506
approved these changes
Feb 11, 2025
Comment on lines
+58
to
+60
| if (jobId == null) { | ||
| throw new GeneralException(CommonErrorCode.NOT_FOUND_BY_JOB_ID); | ||
| } |
Member
There was a problem hiding this comment.
Job에 대해 null 체크를 하는건 어떨까요?
Job이 있으면 jobId가 있는게 보장되서, Job이 있는데 jobId가 없는 경우는 없을거라
.getId()에서 널포인트 예외가 터질 수 있을 것 같아여
Contributor
Author
There was a problem hiding this comment.
Job에 대해 null 체크를 하는건 어떨까요? Job이 있으면 jobId가 있는게 보장되서, Job이 있는데 jobId가 없는 경우는 없을거라 .getId()에서 널포인트 예외가 터질 수 있을 것 같아여
오 넵 이거 한번 수정해둘게요!!
momuzzi
approved these changes
Feb 12, 2025
Comment on lines
+58
to
+60
| if (jobId == null) { | ||
| throw new GeneralException(CommonErrorCode.NOT_FOUND_BY_JOB_ID); | ||
| } |
Member
There was a problem hiding this comment.
Job에 대해 null 체크를 하는건 어떨까요?
Job이 있으면 jobId가 있는게 보장되서, Job이 있는데 jobId가 없는 경우는 없을거라
.getId()에서 널포인트 예외가 터질 수 있을 것 같아여
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 요약 설명
📝 작업 내용
// 핵심 코드를 붙여넣기 해주세요코드에 대한 간단한 설명 부탁드립니다.
동작 확인
💬 리뷰 요구사항(선택)
Summary by CodeRabbit