expanded IMAGE_LOAD_CONFIG_DIRECTORY structs #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Lichtman
force-pushed
the
load_config
branch
3 times, most recently
from
cb672b0 to
343c4d9
Compare
Author
|
Note that this involved changing some of the const assertions made at the bottom of image.rs |
Ben-Lichtman
force-pushed
the
load_config
branch
from
343c4d9 to
5b17ebe
Compare
Author
|
Also note that I have taken these fields from the windows crate eg. https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/System/Diagnostics/Debug/struct.IMAGE_LOAD_CONFIG_DIRECTORY64.html |
Ben-Lichtman
force-pushed
the
load_config
branch
from
5b17ebe to
b5e4ef8
Compare
Author
|
Note: this also adds the packed(4) attribute to IMAGE_LOAD_CONFIG_DIRECTORY64, since this struct may be 4 byte aligned according to the windows SDK eg. https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba01080e93349c2ed/Include/10.0.16299.0/km/ntimage.h#L1746 - This is a breaking change to the pelite API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMAGE_LOAD_CONFIG_DIRECTORY32 and IMAGE_LOAD_CONFIG_DIRECTORY64 did not have all their fields included, so I have added them