Conversation
- expand README notes for first boot and the bundled TShock runtime - rewrite the branch workflow guides and add zh-cn counterparts - sync GitVersion and docs-check with the documented develop/main/release flow
Reviewer's GuideRefactors the documented branch workflow from a three-branch model to a develop→main→release/ model, aligns GitVersion and CI configuration with that workflow (including docs-only checks and release semantics), and expands both English and Simplified Chinese README and branch docs with clearer explanations plus localized counterparts. Sequence diagram for the new release execution processsequenceDiagram
actor Dev as Developer
participant GitHubRepo as GitHub_repository
participant GitVersion as GitVersion_engine
participant Actions as GitHub_Actions
participant ReleasePage as GitHub_Releases
Dev->>GitHubRepo: checkout main
Dev->>GitHubRepo: create branch release_0_2_1 from main
Dev->>GitHubRepo: push release_0_2_1
GitHubRepo-->>Actions: push to release/* (build_workflow)
Actions->>GitVersion: calculate_version(branch=release_0_2_1)
GitVersion-->>Actions: version v0_2_1_rc_N
Actions->>ReleasePage: create_or_update_alpha_prerelease
Dev->>Actions: manual workflow_dispatch Build_and_Release
Actions->>GitVersion: calculate_version(branch=release_0_2_1)
GitVersion-->>Actions: version v0_2_1_rc_or_stable
Actions->>ReleasePage: create_RC_or_stable_release
Dev->>GitHubRepo: continue work on develop for next_cycle
Flow diagram for the updated develop_main_release branch workflowflowchart TD
subgraph Daily_development
D[develop]
end
subgraph Stable_promotion
M[main]
end
subgraph Release_execution
R[release_x_y_z]
end
subgraph Short_lived_branches
F[feature_my_change]
B[bugfix_fix_issue]
DOC[doc_update_docs]
end
F --> D
B --> D
DOC --> D
D -->|stable_snapshot_PR| M
M -->|cut_release_branch| R
R -->|push_commits| R
classDef dev fill:#d0ebff,stroke:#1c7ed6,color:#000
classDef main fill:#d3f9d8,stroke:#2b8a3e,color:#000
classDef release fill:#fff3bf,stroke:#f08c00,color:#000
classDef short fill:#f8f0fc,stroke:#7048e8,color:#000
class D dev
class M main
class R release
class F,B,DOC short
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The updated
docs-check.yamlrunsdotnet restoreonsrc/for any docs-only change; if this begins to impact CI time, consider either skipping the .NET setup/restore when only markdown/docs paths change or narrowingPROJECT_PATHto the minimal solution/project needed forsync-doc-metadata.ps1. - You’ve documented
release/<version>as the canonical release branch prefix while still supportingreleases/*in CI and GitVersion; consider adding a brief note inGitVersion.ymlnear thereleaseregex to explain this dual support so future changes don’t accidentally drop the legacy alias.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The updated `docs-check.yaml` runs `dotnet restore` on `src/` for any docs-only change; if this begins to impact CI time, consider either skipping the .NET setup/restore when only markdown/docs paths change or narrowing `PROJECT_PATH` to the minimal solution/project needed for `sync-doc-metadata.ps1`.
- You’ve documented `release/<version>` as the canonical release branch prefix while still supporting `releases/*` in CI and GitVersion; consider adding a brief note in `GitVersion.yml` near the `release` regex to explain this dual support so future changes don’t accidentally drop the legacy alias.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align repository branch workflow, versioning, and documentation around a develop → main → release/ model and introduce automated doc metadata checks in CI.
Build:
CI:
Documentation:
Chores: