Conversation
Reviewer's GuideUpdates the English and Chinese READMEs to introduce a new multi-world architecture comparison section, rename the architecture section to clarify it as runtime architecture, slightly refine explanatory wording, and adjust the Terraria version source description in the version matrix. Flow diagram for choosing between UnifierTSL and proxy-based architecturesflowchart TD
Start["Designing a multi-world Terraria setup"]
Start --> NeedCrossMachine["Need strong cross-machine / cross-container scaling and isolation?"]
NeedCrossMachine -->|Yes| ChooseProxy["Prefer proxy-based topology"]
NeedCrossMachine -->|No or mostly single-node| FocusSingleNode["Optimizing single-node multi-world behavior"]
FocusSingleNode --> NeedTightConsistency["Need tight in-process consistency for routing, migration, and state transfer?"]
NeedTightConsistency -->|Yes| ChooseUnifier["Prefer UnifierTSL single-process coordination"]
NeedTightConsistency -->|No| PreferEcosystem["Prioritize existing plugin ecosystem with minimal adaptation?"]
PreferEcosystem -->|Yes| ChooseProxy
PreferEcosystem -->|No| ChooseUnifier
ChooseUnifier --> ConsiderHybrid["Optionally place UnifierTSL behind a higher-level gateway / proxy"]
ChooseProxy --> ConsiderHybrid
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In the final Chinese paragraph, consider adding a space between
proxy-basedand the following Chinese text (e.g.,proxy-based 会是你的最优选择) to keep English–Chinese spacing consistent with the rest of the document.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the final Chinese paragraph, consider adding a space between `proxy-based` and the following Chinese text (e.g., `proxy-based 会是你的最优选择`) to keep English–Chinese spacing consistent with the rest of the document.
## Individual Comments
### Comment 1
<location path="README.md" line_range="62" />
<code_context>
From the player's side, this still behaves like a normal Terraria entry point: clients connect to one shared listener port, and `UnifiedServerCoordinator` routes each connection to the selected world inside the same process. If you push this model further, you can build more gameplay-driven setups: fully connected multi-instance world clusters, elastic worlds that load or unload region-sized shards on demand, or private worlds tuned per player for logic and resource budgets.
-These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features, and heavier implementations like these may stay out of the launcher core itself; you can still expect usable example plugins to land under `plugins/` over time.
+These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features, you can still expect usable example plugins to land under `plugins/` over time.
---
</code_context>
<issue_to_address>
**suggestion (typo):** Consider fixing the comma splice by splitting into two sentences or using a semicolon.
This sentence currently joins two independent clauses with only a comma, which is a comma splice. Consider either using a semicolon ("…features; you can still expect…") or splitting into two sentences ("…features. You can still expect…").
```suggestion
These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features; you can still expect usable example plugins to land under `plugins/` over time.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| From the player's side, this still behaves like a normal Terraria entry point: clients connect to one shared listener port, and `UnifiedServerCoordinator` routes each connection to the selected world inside the same process. If you push this model further, you can build more gameplay-driven setups: fully connected multi-instance world clusters, elastic worlds that load or unload region-sized shards on demand, or private worlds tuned per player for logic and resource budgets. | ||
| These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features, and heavier implementations like these may stay out of the launcher core itself; you can still expect usable example plugins to land under `plugins/` over time. | ||
| These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features, you can still expect usable example plugins to land under `plugins/` over time. |
There was a problem hiding this comment.
suggestion (typo): Consider fixing the comma splice by splitting into two sentences or using a semicolon.
This sentence currently joins two independent clauses with only a comma, which is a comma splice. Consider either using a semicolon ("…features; you can still expect…") or splitting into two sentences ("…features. You can still expect…").
Suggested change
| These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features, you can still expect usable example plugins to land under `plugins/` over time. | |
| These are reachable directions, even though the launcher does not currently ship them as default out-of-the-box features; you can still expect usable example plugins to land under `plugins/` over time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Document and clarify the tradeoffs between UnifierTSL and proxy-based multi-world architectures, and align README terminology around runtime architecture and version sourcing.
Documentation: