Skip to content

Update auth provider #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelshin merged 3 commits into from
Apr 22, 2025
Merged

Update auth provider #96

michaelshin merged 3 commits into from
Apr 22, 2025

Conversation

@michaelshin
Copy link
Contributor

@michaelshin michaelshin commented Apr 7, 2025 •
edited
Loading

  • Changed the login so it is compatible with WorkOS. The login flow now uses PKCE from the CLI so the UI does not have to be in the loop
  • For any existing login sessions, the previous credentials will be deleted and the user needs to re-download the tokens
  • Updated the major version as this is a breaking change for users

@michaelshin michaelshin added the enhancement New feature or request label Apr 7, 2025
@michaelshin michaelshin self-assigned this Apr 7, 2025
Dhruv-Mehndhiratta-Centml
Dhruv-Mehndhiratta-Centml requested changes Apr 7, 2025
View reviewed changes
anandj91
anandj91 reviewed Apr 8, 2025
View reviewed changes
@michaelshin michaelshin force-pushed the mshin/update-auth-provider branch from 832767b to 0bbff9c Compare April 9, 2025 18:47
@michaelshin michaelshin force-pushed the mshin/update-auth-provider branch from 0bbff9c to dfaae02 Compare April 9, 2025 18:50
@michaelshin michaelshin changed the title Update auth provider to WorkOS Update auth provider Apr 15, 2025
@michaelshin michaelshin requested a review from c-fteixeira April 15, 2025 19:37
@michaelshin
Copy link
Contributor Author

michaelshin commented Apr 15, 2025

Screenshots of the CLI interactions:
Screenshot 2025-04-15 at 3 27 48 PM

Screenshot of the success page
image

@michaelshin michaelshin merged commit 3199307 into main Apr 22, 2025
4 of 5 checks passed
@michaelshin michaelshin deleted the mshin/update-auth-provider branch April 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anandj91 anandj91 anandj91 approved these changes

@Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml Dhruv-Mehndhiratta-Centml approved these changes

@c-fteixeira c-fteixeira Awaiting requested review from c-fteixeira

Assignees

@michaelshin michaelshin

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelshin @anandj91 @Dhruv-Mehndhiratta-Centml