Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module github.com/centml/platform/ecr-anywhere

go 1.24.1
toolchain go1.24.1

require (
k8s.io/api v0.30.2
Expand Down
3 changes: 2 additions & 1 deletion pkg/credentials/credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ func (ecu *ecrCredentialInjector) Inject(secret *corev1.Secret) (patching.Operat
// Call the API to get ECR credentials
res, err := ecu.ecrClient.GetAuthorizationToken(context.Background(), &ecr.GetAuthorizationTokenInput{})
if err != nil {
return nil, fmt.Errorf("failed to get authorization token: %w", err)
ecu.ErrorLogger.Printf("Failed to get authorization token: %v", err)
panic(fmt.Errorf("failed to get authorization token: %w", err))
}
ecu.InfoLogger.Print("Received authorization data")

Expand Down
13 changes: 9 additions & 4 deletions pkg/credentials/credentials_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,15 +254,20 @@ func TestInject(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
tt.setupMock()

patches, err := injector.Inject(tt.secret)
if tt.expectedError != "" {
assert.EqualError(t, err, tt.expectedError)
if tt.name == "GetAuthorizationToken fails" {
assert.PanicsWithError(t, tt.expectedError, func() {
_, _ = injector.Inject(tt.secret)
})
} else {
_, err := injector.Inject(tt.secret)
assert.EqualError(t, err, tt.expectedError)
}
} else {
patches, err := injector.Inject(tt.secret)
assert.NoError(t, err)
assert.Equal(t, tt.expectedPatches, patches)
}

mockECRClient.AssertExpectations(t)
})
}
Expand Down