Skip to content

patch: panic if unable to get ecr creds #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-fteixeira merged 2 commits into from
Apr 7, 2025
Merged

patch: panic if unable to get ecr creds #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc50ec
patch: panic if unable to get ecr creds
c-fteixeira Apr 5, 2025
3adb19a
chore: fix tests for panic case
c-fteixeira Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module github.com/centml/platform/ecr-anywhere

go 1.24.1
toolchain go1.24.1

require (
k8s.io/api v0.30.2
Expand Down
3 changes: 2 additions & 1 deletion pkg/credentials/credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ func (ecu *ecrCredentialInjector) Inject(secret *corev1.Secret) (patching.Operat
// Call the API to get ECR credentials
res, err := ecu.ecrClient.GetAuthorizationToken(context.Background(), &ecr.GetAuthorizationTokenInput{})
if err != nil {
return nil, fmt.Errorf("failed to get authorization token: %w", err)
ecu.ErrorLogger.Printf("Failed to get authorization token: %v", err)
panic(fmt.Errorf("failed to get authorization token: %w", err))
}
ecu.InfoLogger.Print("Received authorization data")

Expand Down
Loading