Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-7411] poetry and assorted cleanup #852

Open
wants to merge 18 commits into
base: feature/share-cleanupgrade-2025
Choose a base branch
from

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Mar 26, 2025

  • use poetry to install/manage dependencies
    • remove requirements.txt, dev-requirements.txt, constraints.txt
    • add dependencies to pyproject.toml
    • add poetry.lock
    • update Dockerfile and docker-compose.yml to use poetry
  • assorted cleanup
    • update github action to use python 3.13
    • remove (now unused) elasticsearch5 code (including sharev2_elastic5 index strategy)
    • remove (now unused) trove_indexcard_flats index strategy

@aaxelb aaxelb changed the base branch from develop to feature/share-cleanupgrade-2025 March 26, 2025 13:01
@aaxelb aaxelb force-pushed the mob/2025-03-26 branch 2 times, most recently from a3de9f3 to 07840eb Compare March 26, 2025 19:57
@coveralls
Copy link

coveralls commented Mar 26, 2025

Coverage Status

coverage: 77.87% (-1.3%) from 79.162%
when pulling 9e9e3a2 on aaxelb:mob/2025-03-26
into fd3268a on CenterForOpenScience:feature/share-cleanupgrade-2025.

@aaxelb aaxelb changed the title [wip][gizmob] poetry... [ENG-7411] poetry and assorted cleanup Apr 10, 2025
@aaxelb aaxelb marked this pull request as ready for review April 10, 2025 19:17
@aaxelb aaxelb requested a review from felliott April 10, 2025 19:21
Copy link
Member

@felliott felliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I had a couple of small questions, but neither is a dealbreaker.

Cheers,
@felliott

### Dev
FROM app AS dev

RUN pip install --no-cache-dir -c /code/constraints.txt -r /code/dev-requirements.txt
RUN $POETRY_HOME/bin/poetry install --compile --only dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Docker build had a few nitpicks, but these aren't dealbreakers:

 3 warnings found (use docker --debug to expand):                                                                                                                                                           
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 60)
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 61)

@@ -54,32 +48,28 @@ jobs:
- name: install non-py dependencies
run: sudo apt-get update && sudo apt-get install -y libxml2-dev libxslt1-dev libpq-dev git gcc

- name: set up python${{ matrix.python-version }}
- name: Install poetry
run: pipx install poetry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pinned to the same version as the Dockerfile (2.1.1)? I don't have a strong opinion. It might be worth to leave unpinned as a canary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants