[ENG-10108] 1.3.1 FE: update metadata widget to allow searching from ROR instead of CrossRef#872
Open
nsemets wants to merge 4 commits intoCenterForOpenScience:feature/ror-migrationfrom
Open
Conversation
felliott
requested changes
Feb 5, 2026
Member
felliott
left a comment
felliott
left a comment
There was a problem hiding this comment.
Looks pretty good to me! Just a few small changes needed.
| getFundersList(searchQuery?: string): Observable<CrossRefFundersResponse> { | ||
| let url = `${this.funderApiUrl}funders?mailto=support%40osf.io`; | ||
| getFundersList(searchQuery?: string): Observable<RorFunderOption[]> { | ||
| let url = `${this.funderApiUrl}/organizations?filter=types:funder`; |
Member
There was a problem hiding this comment.
ROR now requires a client id in the request headers to get a higher rate-limit. Can you add optional support for that to the code?
Collaborator
Author
There was a problem hiding this comment.
I added code, but I need real client id to test it.
src/app/features/metadata/dialogs/funding-dialog/funding-dialog.component.spec.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes