[ENG-9854][ENG-10025][ENG-10040][ENG-10095] NR Post-release model migration + model dependent bug-fixes #11540
+95
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostap-Zherebetskyi
force-pushed
the
hotfix/NR_model_migration
branch
from
e72dbb2 to
1d70ead
Compare
Ostap-Zherebetskyi
changed the title
Ostap-Zherebetskyi
force-pushed
the
hotfix/NR_model_migration
branch
from
1d70ead to
724cdda
Compare
cslzchen
approved these changes
Jan 8, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
LGTM ⭐
Note: let's take out three hotfix pieces and make a different PR, and I will re-target this PR to feature/notifications-refactor-post-release once 26.1.5 is released.
cslzchen
changed the title
cslzchen
changed the title
…fails with permission error
remove datetime
Ostap-Zherebetskyi
force-pushed
the
hotfix/NR_model_migration
branch
from
48ed72a to
ab06f57
Compare
Ostap-Zherebetskyi
changed the base branch from
hotfix/26.1.5
to
feature/notifications-refactor-post-release
cslzchen
changed the title
cslzchen
approved these changes
Jan 27, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Looks good with a few comments. I will take care of a few and leave the rest (if they make sense) for the future PR.
In addition, I will rename the migration name to 0036_notification_refactor_post_release
| return base_q.annotate(_has_task=Exists(existing_no_login)).filter(_has_task=False) | ||
| # Exclude users who have already received a no-login email recently | ||
| return base_q.filter( | ||
| Q(no_login_email_last_sent__isnull=True) | |
Collaborator
There was a problem hiding this comment.
Since the new check only checks the user field, we need a script to migrate all sent ones to the user model before we clean them up.
cslzchen
approved these changes
Jan 28, 2026
cslzchen
merged commit f6694d8
into
CenterForOpenScience:feature/notifications-refactor-post-release
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-9854
https://openscience.atlassian.net/browse/ENG-10025
https://openscience.atlassian.net/browse/ENG-10040
https://openscience.atlassian.net/browse/ENG-10095
Purpose
Changes
seenfield fromNotificationSide Effects
N/A
QE Notes
N/A
CE Notes
N/A
Documentation
N/A