Feature/settings output#16
Open
JeltevanBoheemen wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13
The implementation is pretty basic. Writes an output file with CLI arguments, corpus config, and some metadata. All in a nice YAML format.
I opted against making this more complex (e.g. tracking status, writing at multiple times). In my view, this only serves as after-the-fact documentation on how the model that is generated came to be.
As discussed, a
(default)suffix would be nice for options that were not explicitly set. Let's consider it a nice-to-have for the future. Again, I think this implementation suffices for documentation purposes.Supplied example file shows how the output looks.