Read a glTF file's external data before postprocessing. #1280
Conversation
An new method `CesiumGltfReader::readGltfAndExternalData` has been added which reads external data and then does postprocessing. Addresses #1034
| assetFetcher.baseUrl, | ||
| options) | ||
| .thenInWorkerThread( | ||
| [&assetFetcher](CesiumGltfReader::GltfReaderResult&& gltfResult) { |
There was a problem hiding this comment.
It's not safe to lambda capture a parameter by reference if the lambda will outlive the function invocation.
| options) | ||
| .thenInWorkerThread( | ||
| [&assetFetcher](CesiumGltfReader::GltfReaderResult&& gltfResult) { | ||
| if (gltfResult.model) { |
There was a problem hiding this comment.
Looks like the convertImmediate function above has been inlined here, so it can be removed.
|
|
||
| result.contentKind = std::move(*gltfResult.model); | ||
| return asyncSystem | ||
| .runInWorkerThread([result = std::move(result), |
There was a problem hiding this comment.
postProcessContentInWorkerThread is already running in a worker thread, so this runInWorkerThread is unnecessary.
CesiumGltfReader/src/GltfReader.cpp
Outdated
| CesiumAsync::HttpHeaders httpHeaders; | ||
| httpHeaders.insert(headers.begin(), headers.end()); |
There was a problem hiding this comment.
| CesiumAsync::HttpHeaders httpHeaders; | |
| httpHeaders.insert(headers.begin(), headers.end()); | |
| CesiumAsync::HttpHeaders httpHeaders(headers.begin(), headers.end()); |
There was a problem hiding this comment.
Thanks @kring for fixing my broken code!
|
I've addressed all of my comments above, but there's a more subtle problem remaining. Previously, |
|
Thanks @timoore! |
An new method
CesiumGltfReader::readGltfAndExternalDatahas been added which reads external data and then does postprocessing.Addresses #1034