Skip to content

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Sep 30, 2025

Description

  • Updated the banner links to the new URLS
  • Updated the prod github workflow to build the new sandcastle and deploy it to the bucket for sandcastle.cesium.com
  • Prevented building development sandcastles in PROD
  • Adjusted the style of the gallery focus to not have it shrink when it appears
  • Ensure that none of the new sandcastle code is in the zip file we distribute. We need to think about the process here a bit more, likely addressed in Sandcastle build config updates #12904

Issue number and link

Testing plan

Mimic prod build

git clean -dxf --exclude="/Specs/e2e/*-snapshots/"
npm install
npm run website-release
PROD=true npm run build-apps
PROD=true npm run build-ts
PROD=true npm run build-prod -w packages/sandcastle -- -l warn
cd Build/Sandcastle2
npx http-server --port 8081
  • Navigate to localhost:8081 and make sure everything loads as expected.
  • Ensure there are no Development sandcastles in this version

Mimic the release zip process

git clean -dxf --exclude="/Specs/e2e/*-snapshots/"
npm install
npm run make-zip
  • Make a temp folder somewhere to extract the zip it created
  • Ensure npm install and npm start work in that directory
  • Make sure the localhost:8080 sandcastle link is the old one
  • Make sure there is no new sandcastle code in the extracted directory

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@jjspace jjspace requested a review from ggetz September 30, 2025 20:53
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good! I'm about to test locally before we go ahead and merge.

In the meantime, could you also add an update to CHANGES.md with a short summary of the updates here? It can be outside of the package updates like the message from the last release.

Comment on lines +486 to +489
<Anchor
href="https://cesium.com/downloads/cesiumjs/releases/1.134/Apps/Sandcastle/index.html"
tone="accent"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening an standalone issue for the plan to fully remove the old Sandcastle? I think it'll be helpful to discuss apart from the "new" Sandcastle plans themselves.

</li>
<li>
<a href="Apps/Sandcastle/index.html">Sandcastle</a>
<a href="Apps/Sandcastle2/index.html">Sandcastle</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should build-sandcastle become part of the build step? Either the build itself, or as part of the initial run on npm start?

It was a bit confusing when I ran:

npm install
npm run make-zip
npm start

but when I clicked on Sandcastle, I still saw

Image

This fix could be a fast follow PR, as it does not impact the release itself.

@ggetz
Copy link
Contributor

ggetz commented Oct 1, 2025

For the sake of time, I went ahead and updated CHANGES.md. Otherwise, things are all working well. Thanks @jjspace!

Please make sure to review the two comments above and determine if any follow-ups are needed.

@ggetz ggetz added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 6e3195b Oct 1, 2025
5 checks passed
@ggetz ggetz deleted the sandcastle-banner-update branch October 1, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants