Skip to content

feat: log tersed tipset key for troubleshooting #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented May 28, 2025

Summary of changes

Changes introduced in this pull request:

  • log tersed tipset key for troubleshooting
2025-05-28T14:07:38.075696Z  INFO forest::chain_sync::chain_follower: Catching up to HEAD: 5004478(eal...v2i, ebx...4mu, ebg...yy2, edp...ul6, ebp...236, ed2...uro) -> 5004495
...
2025-05-28T14:07:48.243932Z  INFO forest::state_manager: Evaluating tipset: EPOCH=5004489, blocks=1, tsk=(ead...lhi)
2025-05-28T14:07:48.777253Z  INFO forest::state_manager: Evaluating tipset: EPOCH=5004491, blocks=1, tsk=(ecf...6va)
2025-05-28T14:07:49.454757Z  INFO forest::state_manager: Evaluating tipset: EPOCH=5004492, blocks=1, tsk=(ecl...2hu)
2025-05-28T14:07:49.974191Z  INFO forest::state_manager: Evaluating tipset: EPOCH=5004493, blocks=6, tsk=(ed7...vhm, ecn...q5k, edo...rzq, eaf...4de, edd...y3g, ebq...ane)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review May 28, 2025 14:13
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 28, 2025 14:13
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team May 28, 2025 14:13
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on this terse format, it makes any debugging annoying; normally you could paste the key into a blockchain explorer and get a result. Nothing useful to be done with the last few characters except for comparing against existing Forest logs.

That said, if you think it's useful then LGTM.

@hanabi1224 hanabi1224 marked this pull request as draft May 29, 2025 12:32
@elmattic
Copy link
Contributor

elmattic commented Jun 4, 2025

I'm not sold on this terse format, it makes any debugging annoying; normally you could paste the key into a blockchain explorer and get a result. Nothing useful to be done with the last few characters except for comparing against existing Forest logs.

That said, if you think it's useful then LGTM.

I’d prefer to keep the full Cid as well, as it’s vital for debugging.

@hanabi1224
Copy link
Contributor Author

@LesnyRumcajs @elmattic changed to printing full tipset key as suggested

@hanabi1224 hanabi1224 marked this pull request as ready for review June 5, 2025 07:50
@hanabi1224 hanabi1224 added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit cecd314 Jun 5, 2025
39 checks passed
@hanabi1224 hanabi1224 deleted the hm/log-tersed-tipset-key branch June 5, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants