Repository navigation
test(ssz): share tree view tests across view types - #816
Draft
spiral-ladder wants to merge 2 commits into
Draft
spiral-ladder wants to merge 2 commits into
spiral-ladder wants to merge 2 commits into
Conversation
The tree view test files repeated the same bodies per view type: five clone tests in seven files, ten serialize tests in five files, and seven bit tests duplicated between bit_list and bit_vector although both delegate to BitArray. Run each set once over its view types from clone_opts_test.zig, root_test.zig and bit_array_test.zig, keeping every pinned vector, and drop the 58 per-file copies. The bit vector OOM test now runs through both bit views as well, which empties bit_vector_test.zig, so that file goes too.
Member
Author
|
one of the cleanups i wanna do before merging codebases, dedups quite a lot of test code, draft now until i clean up some stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The tree view test files repeated the same bodies per view type: five clone tests in seven files, ten serialize tests in five files, and seven bit tests duplicated between bit_list and bit_vector although both delegate to BitArray. Run each set once over its view types from clone_opts_test.zig, root_test.zig and bit_array_test.zig, keeping every pinned vector, and drop the 58 per-file copies. The bit vector OOM test now runs through both bit views as well, which empties bit_vector_test.zig, so that file goes too.
Description
WIP
AI Assistance Disclosure