add readme and created seperate folder#1730
add readme and created seperate folder#1730IshikaAnand7 wants to merge 1 commit intoChameleon-company:masterfrom
Conversation
manya0033
left a comment
There was a problem hiding this comment.
Hey Ishika, I've reviewed the notebook and the PR. The data exploration work is solid, good structure with class balance analysis, pixel intensity profiling, stratified splits, and augmentation previews. A few things need to be addressed before I can approve:
-
PR title format - The title needs to follow the standard: team name, project name (matching Trello card), and completion percentage. "add readme and created seperate folder" doesn't meet this. Something like: "AI | Project 6a: Crack Detection -Data Exploration | X% Completion".
-
PR source - This is coming from IshikaAnand7:master (your personal fork). PRs should come from a dedicated branch after cloning the company repository, not from a forked repo's master branch.
-
Australian English - Found "summarize" in the notebook, should be "summarise".
-
Dataset access - The notebook loads from a local ./dataset directory. The checklist requires datasets to be accessed via API v2.1.
-
Review quality - I'll be honest, the approval from Kavita was a single word ("good") and came through immediately. A proper review should catch things like the points above. I'd also flag that this is the same pattern as Kavita's PR (#1728) where the review was approved very quickly. The review process is there to help each other improve the work, so please make sure your second reviewer does a thorough pass against the checklist.
-
Folder structure - Your notebook is under Playground/project_6a_ishika and Kavita's work is under Playground/project_6a. Since you're both working on the same project, the notebooks should be in a single shared project folder rather than split into separate personal ones. The numbering already suggests a sequence (01, 02, 03) so they belong together.
The notebook content is genuinely good, once these process items are sorted it should be ready. Tag me when you push the updates.
Add SDNET2018 Data Exploration, Balancing, and Augmentation Notebook
Overview
This PR introduces a comprehensive data exploration notebook (
02_sdnet2018_data_exploration.ipynb) that provides end-to-end analysis and preparation of the SDNET2018 crack detection dataset.Key Features
Dataset Structure Supported
Outputs
artifacts/manifests/andartifacts/plots/Use Case
Ideal for crack detection model development, dataset validation, and understanding class imbalance challenges before model training.