Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "How to use" #6

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Add "How to use" #6

merged 1 commit into from
Jun 9, 2019

Conversation

VasenevEA
Copy link
Contributor

No description provided.

@ChasakisD
Copy link
Owner

Thanks for the pull request!

Speaking about initialization, i think the density is not needed. We can calculate the density by divide the canvas' height by the view's height, because canvas' height is in pixels. I will make a PR for it. I'm gonna ping when it's ready, so you can update the initialization and merge it :)

@ChasakisD ChasakisD self-assigned this May 16, 2019
@ChasakisD ChasakisD removed their assignment May 16, 2019
@VasenevEA
Copy link
Contributor Author

Thanks for the pull request!

Speaking about initialization, i think the density is not needed. We can calculate the density by divide the canvas' height by the view's height, because canvas' height is in pixels. I will make a PR for it. I'm gonna ping when it's ready, so you can update the initialization and merge it :)

Ok, I'll be wait for it :)

@ChasakisD
Copy link
Owner

I will make the required changes as soon as I update the initialization process. There is no need for this PR to wait! Thanks @VasenevEA for your contribution :)

@ChasakisD ChasakisD merged commit de639a2 into ChasakisD:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants