Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round corners #7

Merged
merged 5 commits into from
Jun 9, 2019
Merged

Round corners #7

merged 5 commits into from
Jun 9, 2019

Conversation

VasenevEA
Copy link
Contributor

@VasenevEA VasenevEA commented May 22, 2019

Hi!
What do you think about this feature?

I think, if I need to use round corners when Shimmer Animation is active, but I dont want to add frame around every label(for example), and this is no good :)

You can set default CornerRadius and padding of overlay for every element,

<controls:ShimmerLayout 
 CornerRadiusOverlayDefault="10"
 PaddingOverlayDefault="5" />

or set for single element using Attached Property

<controls:ShimmerLayout ... >
<BoxView 
         controls:ShimmerLayout.PaddingOverlay="7,1"
         controls:ShimmerLayout.CornerRadiusOverlay="5"
         ... />
</controls:ShimmerLayout>

Copy link
Owner

@ChasakisD ChasakisD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for the PR! Much appreciated!

Those attached properties are much needed, so you can specify the corner radius per element.
Please check out the comments, and I'll be glad to merge it! :)

BTW the images are not shown

@VasenevEA
Copy link
Contributor Author

I was check out the comments, and modified code

@ChasakisD
Copy link
Owner

@VasenevEA Thanks for the PR :)

@ChasakisD ChasakisD merged commit fa1f2ed into ChasakisD:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants