-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round corners #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thanks for the PR! Much appreciated!
Those attached properties are much needed, so you can specify the corner radius per element.
Please check out the comments, and I'll be glad to merge it! :)
BTW the images are not shown
src/Sample/XFShimmerLayoutSample/XFShimmerLayoutSample/Views/ShimmerListViewPage.xaml
Outdated
Show resolved
Hide resolved
I was check out the comments, and modified code |
@VasenevEA Thanks for the PR :) |
Hi!
What do you think about this feature?
I think, if I need to use round corners when Shimmer Animation is active, but I dont want to add frame around every label(for example), and this is no good :)
You can set default CornerRadius and padding of overlay for every element,
or set for single element using Attached Property