Skip to content

Pre receive feature command (AST-89345) #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 54 commits into
base: main
Choose a base branch
from

Conversation

cx-anjali-deore
Copy link
Contributor

@cx-anjali-deore cx-anjali-deore commented May 16, 2025

By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.

Description

Commands for Pre receive hook feature for secret detection .

Type of Change

  • New feature (non-breaking change which adds functionality)

Related Issues

Link any related issues or tickets.

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the CLI help for new/changed functionality in this PR (if applicable)
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

Screenshots (if applicable)

Add screenshots to help explain your changes.

Additional Notes

Add any other relevant information.

@cx-anjali-deore cx-anjali-deore changed the title Pre-receive feature command(AST-89345) [WIP] [WIP] Pre-receive feature command (AST-89345) May 16, 2025
Copy link

github-actions bot commented May 16, 2025

Logo
Checkmarx One – Scan Summary & Details73e0fb9a-3098-4a01-992f-3fa6099742e6

Great job, no security vulnerabilities found in this Pull Request

@cx-anjali-deore cx-anjali-deore changed the title [WIP] Pre-receive feature command (AST-89345) Pre-receive feature command (AST-89345). May 16, 2025
@cx-anjali-deore cx-anjali-deore changed the title Pre-receive feature command (AST-89345). Prereceive feature command (AST-89345) May 16, 2025
@cx-anjali-deore cx-anjali-deore changed the title Prereceive feature command (AST-89345) Pre receive feature command (AST-89345)[wip] May 16, 2025
@cx-anjali-deore cx-anjali-deore changed the title Pre receive feature command (AST-89345)[wip] Pre receive feature command (AST-89345) May 19, 2025
Copy link
Collaborator

@cx-leonardo-fontes cx-leonardo-fontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cx-anjali-deore What about unit and integration tests? We have detailed tests on the module side, but having some tests here as well, like your team did for the pre-commit feature, would be great.

@cx-anjali-deore
Copy link
Contributor Author

@cx-anjali-deore What about unit and integration tests? We have detailed tests on the module side, but having some tests here as well, like your team did for the pre-commit feature, would be great.

yeah, we have written unit tests. Will add those
For integration tests, waiting for the module, without it , those will fail

@cx-leonardo-fontes
Copy link
Collaborator

@cx-anjali-deore What about unit and integration tests? We have detailed tests on the module side, but having some tests here as well, like your team did for the pre-commit feature, would be great.

yeah, we have written unit tests. Will add those For integration tests, waiting for the module, without it , those will fail

Great, we will let you know when the module is ready to go

Copy link

@cx-celso-silva cx-celso-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cx-anjali-deore please avoid, force pushing, as we were using this branch to set up a demo and caused us rebase to you force push

@cx-anjali-deore
Copy link
Contributor Author

@cx-anjali-deore please avoid, force pushing, as we were using this branch to set up a demo and caused us rebase to you force push

oh sure. Thanks for letting me know

Copy link
Contributor

@cx-anurag-dalke cx-anurag-dalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants