-
Notifications
You must be signed in to change notification settings - Fork 26
Pre receive feature command (AST-89345) #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx-anjali-deore What about unit and integration tests? We have detailed tests on the module side, but having some tests here as well, like your team did for the pre-commit feature, would be great.
yeah, we have written unit tests. Will add those |
Great, we will let you know when the module is ready to go |
9607e2b
to
0e6f03f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx-anjali-deore please avoid, force pushing, as we were using this branch to set up a demo and caused us rebase to you force push
oh sure. Thanks for letting me know |
ee52ae3
to
3456301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
# Conflicts: # internal/commands/pre_commit.go
# Conflicts: # go.mod # Conflicts: # go.sum
3456301
to
08ac679
Compare
* Fix Trivy Vulnerability Co-authored-by: cx-Margarita-LevitM <cx-margarita-levitm>
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Commands for Pre receive hook feature for secret detection .
Type of Change
Related Issues
Link any related issues or tickets.
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.