-
Couldn't load subscription status.
- Fork 349
feat(query): implements "Beta - Google DNS Policy Logging Disabled" #7773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): implements "Beta - Google DNS Policy Logging Disabled" #7773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quality of life change to keep the queries code with the usual structure (following Miguel's review on this PR).
You should also change the name of the folder, completing the rest of the name with _ please.
From:
assets/queries/terraform/gcp/google_dns_policy logging disabled to assets/queries/terraform/gcp/google_dns_policy_logging_disabled
assets/queries/terraform/gcp/google_dns_policy logging disabled/query.rego
Outdated
Show resolved
Hide resolved
…re_that_cloud_dns_logging_is_enabled_for_all_vpc_networks
…_dns_logging_is_enabled_for_all_vpc_networks' of https://github.com/Checkmarx/kics into AST-116619_6_2-Logging_and_Monitoring_ensure_that_cloud_dns_logging_is_enabled_for_all_vpc_networks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…re_that_cloud_dns_logging_is_enabled_for_all_vpc_networks








Reason for Proposed Changes
Proposed Changes
true.I submit this contribution under the Apache-2.0 license.