Skip to content

Conversation

@cx-andre-pereira
Copy link
Contributor

@cx-andre-pereira cx-andre-pereira commented Oct 16, 2025

Reason for Proposed Changes

Proposed Changes

  • Implemented the missing query.
  • The query's logic is extremely simple, all it does is flag if the "enable_logging" field is missing/null or if it is set to a value that is not true.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature terraform Terraform query labels Oct 16, 2025
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review October 17, 2025 09:25
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner October 17, 2025 09:25
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quality of life change to keep the queries code with the usual structure (following Miguel's review on this PR).
You should also change the name of the folder, completing the rest of the name with _ please.
From:
assets/queries/terraform/gcp/google_dns_policy logging disabled to assets/queries/terraform/gcp/google_dns_policy_logging_disabled

…re_that_cloud_dns_logging_is_enabled_for_all_vpc_networks
…_dns_logging_is_enabled_for_all_vpc_networks' of https://github.com/Checkmarx/kics into AST-116619_6_2-Logging_and_Monitoring_ensure_that_cloud_dns_logging_is_enabled_for_all_vpc_networks
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…re_that_cloud_dns_logging_is_enabled_for_all_vpc_networks
@cx-andre-pereira cx-andre-pereira merged commit d00a008 into master Oct 28, 2025
28 checks passed
@cx-andre-pereira cx-andre-pereira deleted the AST-116619_6_2-Logging_and_Monitoring_ensure_that_cloud_dns_logging_is_enabled_for_all_vpc_networks branch October 28, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants