- 
                Notifications
    You must be signed in to change notification settings 
- Fork 349
feat(query): implements "Beta - SQL DB Instance With Exposed Show Privileges" #7776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice addition André.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice case addition, I hadn't found this link before:
https://discuss.google.dev/t/terraform-variables-for-setting-mysql-database-flags/102268/2
Apparently we can support this format as well.
…t_the_'skip_show_database'_database_flag_for_cloud_sql_mysql_intance_is_set_to_off
…16622_9_6.1-MySQL_Database_ensure_that_the_'skip_show_database'_database_flag_for_cloud_sql_mysql_intance_is_set_to_off
…t_the_'skip_show_database'_database_flag_for_cloud_sql_mysql_intance_is_set_to_off








Reason for Proposed Changes
Currently there is no query to ensure that a "google_sql_database_instance" resource with a "MYSQL" based "database_version" has the '
skip_show_database' flag enabled.Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 210: "
skip_show_database database flag prevents people from using the SHOW DATABASES statement if they do not have the SHOW DATABASES privilege. This can improve security if you have concerns about users being able to see databases belonging to other users."Proposed Changes
"Datadog" reference
I submit this contribution under the Apache-2.0 license.