Skip to content

feat(query): implements "Beta - SQL DB Instance With Local Data Loading Enabled" #7777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat(query): implements "Beta - SQL DB Instance With Local Data Loading Enabled" #7777

wants to merge 10 commits into from

Conversation

@cx-andre-pereira
Copy link
Contributor

Reason for Proposed Changes

  • Currently there is no query to ensure that a "google_sql_database_instance" resource with a "MYSQL" based "database_version" has the 'local_infile' flag disabled.

  • Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 213: "Due to security issues associated with the local_infile flag, it is recommended to disable it. This recommendation is applicable to MySQL database instances."

Proposed Changes

  • Implemented the missing query.
  • The query will flag for 4 separate instances : (all after ensuring "database_version" is MYSQL based)
    • Missing the "settings" field
    • Missing the "settings.database_flags" field
    • Missing a definition for the "local_infile" flag on the "database_flags" field
    • Setting the "local_infile" flag to a value that is not "off"

"Datadog" reference

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added feature New feature query New query feature terraform Terraform query labels Oct 20, 2025
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review October 20, 2025 13:05
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner October 20, 2025 13:05
cx-artur-ribeiro
cx-artur-ribeiro previously approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job André!

cx-artur-ribeiro
cx-artur-ribeiro previously approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-andre-pereira
Merge branch 'master' into AST-116623_10_6.1-MySQL_Database_ensure_th…
3dd3eca 
…at_the_'local_infile'_database_flag_for_a_cloud_sql_mysql_instance_is_set_to_off
@cx-andre-pereira
fixed tests
a5779d7
@cx-andre-pereira
Merge branch 'master' of https://github.com/Checkmarx/kics into AST-1…
dbd0752 
…16623_10_6.1-MySQL_Database_ensure_that_the_'local_infile'_database_flag_for_a_cloud_sql_mysql_instance_is_set_to_off
@cx-andre-pereira
simId transition update
efd696a
@cx-andre-pereira
metadata update
10b7991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cx-andre-pereira cx-andre-pereira

Labels

feature New feature query New query feature terraform Terraform query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-andre-pereira @cx-artur-ribeiro