Enable management of MKP packages with server role #714
Conversation
Release 5.4.0
Update changelogs and docs upon release
github-actions
bot
added
documentation
|
Thanks for this contribution @ra2xfael, looks pretty neat! 💪 |
There was a problem hiding this comment.
So I have this problem: In distributed monitoring, MKPs will be replicated from a central to the remote sites upon activating changes. So MKP management would only ever make sense on a central site in this scenario.
Now your changes do enable this, as MKP management can be configured on a per-site basis. I am just uncertain at this point, if we need to build safeguards or if providing documentation and maybe a warning will suffice.
| mkp_packages: | ||
| - name: 'mypackage' | ||
| version: 1.0 | ||
| src: 'path' | ||
| url: 'download' | ||
| checksum: 'md5:download checksum' | ||
| installed: true | ||
| enabled: true | ||
|
|
||
| A dictionary of sites, containing the desired version, admin password and state. | ||
| MKP packages can be listed to be installed on the specific site. A source can be set on the ansible controller. Alternatively a url can be specified to download the mkp package from. |
There was a problem hiding this comment.
Not sure, if this is getting to convoluted here, but I got no better idea, so I am just mentioning it.
| @@ -56,3 +56,5 @@ checkmk_server_epel_gpg_check: 'true' | |||
|
|
|||
| checkmk_server_cleanup: 'false' | |||
| checkmk_server_no_log: 'true' | |||
|
|
|||
| checkmk_server_mkp_staging: '/tmp' | |||
There was a problem hiding this comment.
I think we should add a global tmp dir variable, like in the agent role: __checkmk_agent_host_tmp_dir.
That should obviously be done in a dedicated PR ahead of this one. Would you want to take that on @ra2xfael?
But why make it configurable in the first place?
This pull request tries to enable the installation and management of MKP packages specified by site. Packages can be downloaded or provided on the ansible controller and will be installed, enabled, disabled or removed from the sites.
Pull request type
What is the current behavior?
CheckMK MKP packages installation and management is not possible with the server role.
What is the new behavior?