service discovery: more details for changed/added/remove discovery pa…

…rameters Add a magnifying glass icon to be able to show more details for changed/added/removed discovery parameters. CMK-21702 Change-Id: I545e8e3d5838215064c77c81ec84f9a24ff97fa9
Checkmk · Feb 12, 2025 · 2453978 · 2453978
1 parent a550bec
commit 2453978
Showing 1 changed file with 22 additions and 0 deletions.
diff --git a/cmk/gui/wato/pages/services.py b/cmk/gui/wato/pages/services.py
@@ -1061,6 +1061,7 @@ def _show_check_row(
                 changed_labels,
                 added_labels,
                 removed_labels,
+                entry.old_discovered_parameters,
                 changed_parameters,
                 added_parameters,
                 removed_parameters,
@@ -1113,6 +1114,7 @@ def _show_discovered_changes(
         changed_labels: Labels,
         added_labels: Labels,
         removed_labels: Labels,
+        old_parameters: Mapping[str, Any],
         changed_parameters: Mapping[str, Any],
         added_parameters: Mapping[str, Any],
         removed_parameters: Mapping[str, Any],
@@ -1139,7 +1141,17 @@ def _show_discovered_changes(
                     len(changed_parameters),
                 )
                 % len(changed_parameters)
+                + html.render_icon(
+                    "search",
+                    _("Old: %r\nNew: %r")
+                    % (
+                        {k: v for k, v in old_parameters.items() if k in changed_parameters},
+                        changed_parameters,
+                    ),
+                    cssclass="iconbutton",
+                )
             )
+
         if added_parameters:
             html.p(
                 ungettext(
@@ -1148,6 +1160,11 @@ def _show_discovered_changes(
                     len(added_parameters),
                 )
                 % len(added_parameters)
+                + html.render_icon(
+                    "search",
+                    _("New: %r") % added_parameters,
+                    cssclass="iconbutton",
+                )
             )
         if removed_parameters:
             html.p(
@@ -1157,6 +1174,11 @@ def _show_discovered_changes(
                     len(removed_parameters),
                 )
                 % len(removed_parameters)
+                + html.render_icon(
+                    "search",
+                    _("Removed: %r") % removed_parameters,
+                    cssclass="iconbutton",
+                )
             )
 
     def _show_status_detail(self, entry: CheckPreviewEntry) -> None: