Improved error message for invalid RPN

Change-Id: I09ed9ac8e43cd040d752b2513e0c39f5dedd1928
Checkmk · Feb 13, 2025 · d321ec6 · d321ec6
1 parent fecf5fd
commit d321ec6
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/livestatus/src/RRDColumn.cc b/packages/livestatus/src/RRDColumn.cc
@@ -277,7 +277,13 @@ std::vector<RRDDataMaker::value_type> RRDDataMaker::make(
     auto [ptr, ec] =
         std::from_chars(dsname_view.begin(), dsname_view.end(), dsname);
     if (ec != std::errc{}) {
-        Warning(logger) << "Invalid location: " << location.data_source_name_;
+        Warning(logger)
+            << "cannot locate an RRD containing the metric of the RPN expression '"
+            << args_.rpn << "' for the "
+            << (service_description == dummy_service_description()
+                    ? "host '" + host_name + "'"
+                    : "service '" + host_name + ";" + service_description +
+                          "'");
         return {};
     }