Add check_disk_smb results handling #848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbclient results NT_STATUS_NO_LOGON_SERVERS and NT_STATUS_IO_TIMEOUT return CRITICAL with dedicated message instead of UNKNOWN with message "Result from smbclient not suitable"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
Some results of smbclient command in check_disk_smb returns default state UNKNOWN with summary "Result from smbclient not suitable". This PR adds handling of two additional results:
NT_STATUS_NO_LOGON_SERVERS=> CRITICAL - No logon serversNT_STATUS_IO_TIMEOUT=> CRITICAL - TimeoutDefault remains: UNKNOWN with summary "Result from smbclient not suitable".
Context
A service SMB Share flapping between UNKNOWN and CRITICAL states as some smbclient results fall into default case:
The smbclient results have been identified as:
Proposed changes
Add conditional matching of the two identified results, in order for the service check to return dedicated state and summary.
The two new conditions are added after the existing ones, to avoid risk of altering existing conditions outcome. This is important for the NT_STATUS_IO_TIMEOUT, as connection issue could also contain error NT_STATUS_IO_TIMEOUT:
After change: