Skip to content

Do not hold onto model as a property in view classes; use src model a… #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sripriya22 merged 1 commit into from
Feb 9, 2026
Merged

Do not hold onto model as a property in view classes; use src model a… #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions code/ConcTimecourseView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
classdef ConcTimecourseView < handle

properties ( Access = private )
Model

properties ( Access = private )
ConcColors = [0.30,0.75,0.93;...
0.86,0.55,0.41;...
0.91,0.73,0.42]; % colors to plot concentrations
Expand Down Expand Up @@ -60,7 +58,6 @@
obj.DataListener = dataListener;

% save objects
obj.Model = model;
obj.Axes = ax;

end % constructor
Expand All @@ -70,8 +67,8 @@

methods ( Access = private )

function update(obj,~,~)
t = obj.Model.SimDataTable;
function update(obj,srcModel,~)
t = srcModel.SimDataTable;

set(obj.lhDrug,'XData',t.Time, 'YData',t.Drug);
set(obj.lhReceptor,'XData',t.Time, 'YData',t.Receptor);
Expand Down
9 changes: 2 additions & 7 deletions code/LampView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@
LampObj
end

properties ( Access=private )
Model
end

properties( Access = private )
DataListener % listener
end
Expand All @@ -42,7 +38,6 @@
obj.DataListener = dataListener;

obj.LampObj = lampObj;
obj.Model = model;

end % constructor

Expand All @@ -68,8 +63,8 @@

methods ( Access = private )

function update(obj,~,~)
obj.IsOn = obj.Model.ROIsBetweenThresholds;
function update(obj,srcModel,~)
obj.IsOn = srcModel.ROIsBetweenThresholds;
end % update

end % private method
Expand Down
8 changes: 3 additions & 5 deletions code/NCAView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
classdef NCAView < handle

properties ( Access = private )
Model
properties ( Access = private )
NCApanel
GridLayout
BackgroundColor = [1,1,1]
Expand Down Expand Up @@ -67,7 +66,6 @@
obj.DataListener = dataListener;

% save objects
obj.Model = model;
obj.NCAoptions = opt;
obj.NCApanel = ncapanel;
obj.GridLayout = gl;
Expand All @@ -89,10 +87,10 @@

methods ( Access = private )

function update(obj,~,~)
function update(obj,srcModel,~)

% compute NCA parameters and display them in table
ncaParameters = sbionca(obj.Model.SimDataTable, obj.NCAoptions);
ncaParameters = sbionca(srcModel.SimDataTable, obj.NCAoptions);
obj.NCAtable.ColumnName = ncaParameters.Properties.VariableNames(2:end);
obj.NCAtable.Data = ncaParameters(:,2:end);

Expand Down
9 changes: 3 additions & 6 deletions code/ROTimecourseView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
classdef ROTimecourseView < handle

properties ( Access = private )
Model

properties ( Access = private )
ThresholdStyle = {'Color','r','Linewidth',2,'LineStyle','--',...
'FontWeight','bold','LabelVerticalAlignment','middle'}; % style for threshold lines

Expand Down Expand Up @@ -60,7 +58,6 @@
obj.DataListener = dataListener;

% save objects
obj.Model = model;
obj.Axes = ax;

end % constructor
Expand All @@ -70,8 +67,8 @@

methods ( Access = private )

function update(obj,~,~)
t = obj.Model.SimDataTable;
function update(obj,srcModel,~)
t = srcModel.SimDataTable;

set(obj.lhRO,'XData',t.Time, 'YData',100*t.RO);

Expand Down