Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fewer maturin references #428

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

fewer maturin references #428

wants to merge 32 commits into from

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Mar 9, 2024

Draft For:

Copy link

coveralls-official bot commented Mar 9, 2024

Pull Request Test Coverage Report for Build 11126670346

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.466%

Totals Coverage Status
Change from base Build 11081723243: 0.0%
Covered Lines: 12509
Relevant Lines: 14987

💛 - Coveralls

Copy link

socket-security bot commented Mar 9, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@altendky altendky closed this Mar 12, 2024
@altendky altendky reopened this Mar 12, 2024
llp.sh Outdated
@@ -0,0 +1,3 @@
# TODO: avoid needing this

export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:$(python -c 'import sysconfig; print(sysconfig.get_config_var("LIBDIR"))')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this is for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't remember either... and it was in my op todo list to look at it. let's give it a try without.

Suggested change
export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:$(python -c 'import sysconfig; print(sysconfig.get_config_var("LIBDIR"))')
#export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:$(python -c 'import sysconfig; print(sysconfig.get_config_var("LIBDIR"))')

@arvidn
Copy link
Contributor

arvidn commented Jan 30, 2025

looks like a good approach to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants