Skip to content

Feature/make pri support - #7

Merged
Choochmeque merged 2 commits into
Choochmeque:mainfrom
clFaster:feature/make-pri-support
Feb 25, 2026
Merged

Feature/make pri support#7
Choochmeque merged 2 commits into
Choochmeque:mainfrom
clFaster:feature/make-pri-support

Conversation

@clFaster

@clFaster clFaster commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Adds support for generating resources.pri files using makepri.exe during MSIX package creation, improving qualified asset resolution for Windows apps.

Introduces a new CLI option (--makepri) and corresponding library functionality, updates documentation, and enhances SDK tool auto-discovery to include makepri.exe.

Additionally, the WACK validation process is made more robust Windows App Certification Kit | Microsoft Learn

New CLI arguments:

--makepri                    # generate resources.pri with MakePri before packing.
--makepri-path               # override the makepri.exe path (requires --makepri).
--makepri-default-language   # default resource language (default: en-us, requires --makepri).
--makepri-target-os-version  # target OS version for MakePri /pv (default: 10.0.0, requires --makepri).
--makepri-keep-config        # keep generated priconfig.xml after MakePri (default: false, requires --makepri).

Relates to: Choochmeque/tauri-windows-bundle#28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for generating resources.pri files using makepri.exe during MSIX package creation, which improves qualified asset resolution for Windows apps (e.g., scale-qualified images like logo.scale-200.png). The PR also enhances WACK validation robustness by adding a reset command before validation, improving report filename uniqueness, and providing better error messages with report paths.

Changes:

  • Adds compile_resources_pri() function and supporting infrastructure to the library
  • Introduces new CLI options (--makepri, --makepri-path, --makepri-default-language, --makepri-target-os-version, --makepri-keep-config)
  • Enhances WACK validation with session reset and improved error reporting
  • Updates all documentation (library, CLI, and root README files)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
msixbundle/src/lib.rs Adds MakePri support with PriOptions, compile_resources_pri(), helper functions, SDK tool discovery for makepri.exe, improved WACK validation, and unit tests
msixbundle-cli/src/main.rs Integrates MakePri functionality with new CLI arguments and calls to compile_resources_pri() for both x64 and arm64 architectures
msixbundle/tests/integration.rs Adds test_compile_resources_pri() test and updates existing multi-arch tests to generate resources.pri when makepri.exe is available
msixbundle/README.md Documents the new compile_resources_pri() function with usage examples and updates requirements
msixbundle-cli/README.md Adds documentation for new MakePri CLI options with examples
README.md Updates feature list and workflow description to include resource indexing step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Choochmeque
Choochmeque merged commit 8d2c8b1 into Choochmeque:main Feb 25, 2026
8 checks passed
@Choochmeque

Copy link
Copy Markdown
Owner

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants