Feature/make pri support - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for generating resources.pri files using makepri.exe during MSIX package creation, which improves qualified asset resolution for Windows apps (e.g., scale-qualified images like logo.scale-200.png). The PR also enhances WACK validation robustness by adding a reset command before validation, improving report filename uniqueness, and providing better error messages with report paths.
Changes:
- Adds
compile_resources_pri()function and supporting infrastructure to the library - Introduces new CLI options (
--makepri,--makepri-path,--makepri-default-language,--makepri-target-os-version,--makepri-keep-config) - Enhances WACK validation with session reset and improved error reporting
- Updates all documentation (library, CLI, and root README files)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| msixbundle/src/lib.rs | Adds MakePri support with PriOptions, compile_resources_pri(), helper functions, SDK tool discovery for makepri.exe, improved WACK validation, and unit tests |
| msixbundle-cli/src/main.rs | Integrates MakePri functionality with new CLI arguments and calls to compile_resources_pri() for both x64 and arm64 architectures |
| msixbundle/tests/integration.rs | Adds test_compile_resources_pri() test and updates existing multi-arch tests to generate resources.pri when makepri.exe is available |
| msixbundle/README.md | Documents the new compile_resources_pri() function with usage examples and updates requirements |
| msixbundle-cli/README.md | Adds documentation for new MakePri CLI options with examples |
| README.md | Updates feature list and workflow description to include resource indexing step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating
resources.prifiles usingmakepri.exeduring MSIX package creation, improving qualified asset resolution for Windows apps.Introduces a new CLI option (
--makepri) and corresponding library functionality, updates documentation, and enhances SDK tool auto-discovery to includemakepri.exe.Additionally, the WACK validation process is made more robust Windows App Certification Kit | Microsoft Learn
New CLI arguments:
Relates to: Choochmeque/tauri-windows-bundle#28