Repository navigation
Fix missing conflict_blacklist.py causing deploy/restore failures in 2.5.0-beta.4 - #534
Closed
justinmiller87 wants to merge 1 commit into
Closed
justinmiller87 wants to merge 1 commit into
justinmiller87 wants to merge 1 commit into
Conversation
Utils/filegraph/adapter.py imports Utils.games.conflict_blacklist (effective_rules), but src/Utils/games/meson.build never listed conflict_blacklist.py in its install_sources(), so builds packaged without it. Any deploy/restore path that touches file-graph state fails with ModuleNotFoundError: No module named 'Utils.games.conflict_blacklist'. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
I've already fixed this for the next beta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Utils/filegraph/adapter.pyimportsUtils.games.conflict_blacklist.effective_rules(_refresh_blacklist), butsrc/Utils/games/meson.buildnever listedconflict_blacklist.pyin itspy.install_sources().v2.5.0-beta.4Flatpak) fails on any deploy/restore path that touches file-graph state:Test plan
meson install) from this branch and confirmUtils/games/conflict_blacklist.pyis present in the installedsite-packages.ModuleNotFoundError: No module named 'Utils.games.conflict_blacklist'.🤖 Generated with Claude Code
https://claude.ai/code/session_01RWuM6MXZhDwBLVfapSML2W