test(app-it): fixtures for the Vite + React, SvelteKit, and Astro recipes - #24
Open
Firnschnee wants to merge 4 commits into
Open
test(app-it): fixtures for the Vite + React, SvelteKit, and Astro recipes#24Firnschnee wants to merge 4 commits into
Firnschnee wants to merge 4 commits into
Conversation
Reviewer's GuideAdds build-assert fixtures and tests for the Vite + React, SvelteKit, and Astro dev-server recipes in app-it, including minimal fixture projects, test-fixture sections, and documentation updates. Sequence diagram for new fixture flow in test-fixtures.shsequenceDiagram
participant TestFixtures as test-fixtures.sh
participant Fixture as vite-react_fixture
participant Inspect as inspect.sh
participant Build as desktop-build.sh
participant AssertBundle as assert_bundle
TestFixtures->>Fixture: select vite-react fixture
TestFixtures->>Inspect: inspect.sh (vite-react)
Inspect-->>TestFixtures: framework detection
TestFixtures->>TestFixtures: assert config-file detection
TestFixtures->>TestFixtures: assert dev-script inventory
TestFixtures->>TestFixtures: assert recipe line
TestFixtures->>Build: desktop-build.sh (vite-react)
Build-->>TestFixtures: bundle artifacts
TestFixtures->>AssertBundle: assert_bundle (vite-react)
AssertBundle-->>TestFixtures: bundle assertions passed
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backs the Vite + React, SvelteKit, and Astro recipes (added in #15) with the fixtures the recipe-governance rule requires (CONTRIBUTING.md: each recipe should land with its fixture).
Each is a build-assert fixture modeled on
next-basic(detection + bundle assembly, no runtime; single-server runtime stays covered byvite-basic):vite-react(port 41100) proves the Vite + React detection branch, whichvite-basic's plain-Vite shape does not exercise.sveltekit-basic(port 41110) proves SvelteKit detection.astro-basic(port 41120) proves Astro detection (port 4321).Each adds a tiny project shape under
scripts/fixtures/<name>/plus one section inscripts/test-fixtures.shthat asserts the config-file detection, the dev-script inventory, and the recipe line, thenbuild+assert_bundle. The fixtures README table and CHANGELOG are updated.The detection half was verified locally; the build/bundle assertions run on the macOS CI lane.
Closes #2, #3, #4.
Summary by Sourcery
Add new behavioral fixtures to validate Vite + React, SvelteKit, and Astro app-it recipes via detection and bundle assembly.
New Features:
Enhancements: