Clean up first part of vortex notebook.#2
Open
ketch wants to merge 1 commit intoChristina-wg:2d_vortexfrom
Open
Clean up first part of vortex notebook.#2ketch wants to merge 1 commit intoChristina-wg:2d_vortexfrom
ketch wants to merge 1 commit intoChristina-wg:2d_vortexfrom
Conversation
Clear output. Improve formatting. Clarify some text and comments. Remove redundant code.
Author
|
Also, I wouldn't refer to the plots you've created as "schlieren plots", since you're using a red-white-blue color map. Since there are no shock waves in this problem, it's probably not best to use a schlieren plot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't go over the whole notebook, but I made some cosmetic improvements to the early part. Note that, due to size and a desire for clean diffs, we store notebooks without output on Github.
There are some formulas in the code that don't match the formulas in the text. I didn't try to fix them since I don't know which is right and which is wrong, but they should be corrected.
Note that
num_output_timesis not the number of time steps: https://www.clawpack.org/pyclaw/output.html#when-output-is-saved-writtenThe term "grid size" is potentially confusing since it's often used to refer to$\Delta x$ .