fix: manage third-party element handle lifetimes - #2452
Open
haopengmai wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
haopengmai
force-pushed
the
fix/retain-third-party-element-handles
branch
from
July 31, 2026 06:48
2314a34 to
7a64f97
Compare
haopengmai
marked this pull request as ready for review
July 31, 2026 06:49
Collaborator
|
@Lightning00Blade could be a regression from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpPageonly after a snapshot succeedsRoot cause
TextSnapshotstored third-party element handles in snapshot nodes while also mutatingMcpPage.extraHandlesimplicitly. The explicit resource-management change in #2443 then disposed those handles as soon as snapshot creation completed, so UIDs for elements outside the accessibility tree immediately referenced disposed handles.The page-side stash also accumulated elements across tool calls, and retained handles were not invalidated on navigation or protected against teardown races.
This change makes ownership explicit:
McpPageowns retained output anchorsTextSnapshotonly consumes anchors and mints a fresh handle per lookupUser impact
UIDs returned by third-party developer tools remain reusable across subsequent tool calls, including detached or otherwise non-accessible DOM elements. Old resources are released deterministically instead of leaking or surviving navigation and teardown.
Tests
npm run check-formatPUPPETEER_EXECUTABLE_PATH='/Applications/Google Chrome.app/Contents/MacOS/Google Chrome' npm run test tests/tools/thirdPartyDeveloper.test.tsPUPPETEER_EXECUTABLE_PATH='/Applications/Google Chrome.app/Contents/MacOS/Google Chrome' npm run test tests/McpPage.test.ts tests/McpContext.test.ts tests/PageCollector.test.ts tests/TextSnapshot.test.ts tests/tools/input.test.ts tests/tools/script.test.ts tests/tools/snapshot.test.ts tests/tools/thirdPartyDeveloper.test.ts