Add support for piping into wsl-sudo.py #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the following work: echo "foo" | ./wsl-sudo.py cat Without these changes, cat would hang indefinitely on the pipe. Fix the issue by: 1. Prevent the server process from inheriting the client's stdin, by explicitly setting its stdin to subprocess.DEVNULL. The primary reason for this is to prevent the server process from messing up the client's stdin pipe. It's unclear if there is an issue with wsl, but letting the server inherit the pipe seems to consume it, leaving nothing for the client to read. Besides, the server receives all of its input from the client-server socket, so it doesn't even need the client's stdin. 2. Send an empty string CMD_STDIN command from the client to the server when a empty chunk is read from stdin. The client already uses 'empty string' to detect a closed pipe, and now, by also transmitting an empty string to the server, the server can do the same. 3. Receive the empty string CMD_STDIN in the server's transfer loop, closing the server's child process stdin in response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the following work:
Without these changes, cat would hang indefinitely on the pipe.
Fix the issue by:
subprocess.DEVNULL. The primary reason for this is to prevent the server process from messing up the client's stdin pipe. It's unclear if there is an issue with wsl, but letting the server inherit the pipe seems to consume it, leaving nothing for the client to read.Besides, the server receives all of its input from the client-server socket, so it doesn't even need the client's stdin.
CMD_STDINcommand from the client to the server when a empty chunk is read from stdin. The client already uses 'empty string' to detect a closed pipe, and now, by also transmitting an empty string to the server, the server can do the same.CMD_STDINin the server's transfer loop, closing the server's child process stdin in response.