Skip to content

refactor: migrate i18n.js to TypeScript as i18n.ts #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: migrate i18n.js to TypeScript as i18n.ts #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/simulator/src/i18n.js
View file
Open in desktop

This file was deleted.

26 changes: 26 additions & 0 deletions src/simulator/src/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import Banana from 'banana-i18n'

// Ensure `window.locale` is typed (you can extend Window interface if needed)
const userLocale = (window as any).locale as string || 'en'

const banana = new Banana()
banana.setLocale(userLocale)

const locale = banana.locale
const finalFallback = 'en'

// Load default (fallback) messages
const messages: Record<string, any> = {
[finalFallback]: require(`./i18n/${finalFallback}.json`),
}

// Try to load user's locale file
try {
messages[locale] = require(`./i18n/${locale}.json`)
} catch (err) {
console.warn(`Could not load locale file for ${locale}, falling back to ${finalFallback}.`)
}

Comment on lines +17 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Set fallback locale on load failure.
If loading the user locale fails, banana.locale remains the unavailable locale. Reset it to the fallback to avoid missing translations at runtime:

try {
  messages[locale] = require(`./i18n/${locale}.json`)
} catch (err) {
  console.warn(`Could not load locale file for ${locale}, falling back to ${fallbackLocale}.`)
+ banana.setLocale(fallbackLocale)
}

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In src/simulator/src/i18n.ts around lines 17 to 23, when loading the user's
locale file fails, the code only logs a warning but does not reset the locale to
the fallback. Modify the catch block to set banana.locale to finalFallback after
logging the warning, ensuring the application uses the fallback locale and
avoids missing translations at runtime.

banana.load(messages)

export default banana