Fix MCP auth bypass by failing on missing credentials#74
Closed
DavidJBianco wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_connect_http_server/SSE treat missing credentials as a successful connection and record unauthenticated clients.Description
MCPClientManager._get_auth_headersreturn type toOptional[Dict[str, str]]and made it returnNoneon auth failures (missing bearer token, incomplete API key config, or unavailable OAuth credentials) while still returning{}for servers with no auth configured._connect_http_serverto abort when_get_auth_headersreturnsNone.tests/unit_tests/test_mcp_oauth_env_vars.pyto expectNonefor auth-failure cases instead of an empty dict.peak_assistant/utils/mcp_config.pyandtests/unit_tests/test_mcp_oauth_env_vars.py.Testing
python -m py_compile peak_assistant/utils/mcp_config.py tests/unit_tests/test_mcp_oauth_env_vars.pywhich succeeded.pytest -q tests/unit_tests/test_mcp_oauth_env_vars.pyandPYTHONPATH=. pytest -q tests/unit_tests/test_mcp_oauth_env_vars.py, both of which could not complete in this environment due to a missing dependency (python-dotenv).Nonefailure contract; remaining test failures are environmental (missing package) rather than regressions in the change set.Codex Task