Fix mutable default previous_run parameters across assistants#83
Closed
DavidJBianco wants to merge 1 commit into
Closed
Fix mutable default previous_run parameters across assistants#83DavidJBianco wants to merge 1 commit into
DavidJBianco wants to merge 1 commit into
Conversation
4 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
previous_run: list = list()in multiple assistant entrypoints, which can retain state across invocations and leak prior session context in multi-user or server scenarios.Description
previous_run: list = list()with safe optional defaultsprevious_run: Optional[list] = Nonein assistant entrypoints.Optionalto type imports where required so annotations remain explicit and valid.peak_assistant/able_assistant/__init__.py,peak_assistant/data_assistant/__init__.py,peak_assistant/hypothesis_assistant/hypothesis_refiner_cli.py,peak_assistant/planning_assistant/__init__.py, andpeak_assistant/research_assistant/__init__.pyto remove the shared-list pattern while preserving existing function signatures and behavior.Testing
python -m compileall -q peak_assistantto verify the package compiles, and it succeeded.previous_run: list = list()underpeak_assistantusing a repository search, and the check returned no matches.Codex Task