Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGOV-440: Basic auth for frontend application and fix for broken images #55

Merged
merged 4 commits into from
Feb 3, 2025
Merged

PGOV-440: Basic auth for frontend application and fix for broken images #55

merged 4 commits into from
Feb 3, 2025

Conversation

acabouet
Copy link
Collaborator

No description provided.

@acabouet acabouet requested a review from dgading January 27, 2025 08:30
dgading
dgading requested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@dgading dgading left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally this worked great. I was able to get all the images loading without the popup as I switched pages.

src/frontend/middleware.ts Outdated Show resolved Hide resolved
@acabouet acabouet force-pushed the pgov-440-basic-auth-frontend branch from 57ca0fa to 1176919 Compare February 3, 2025 03:55
@acabouet acabouet requested a review from dgading February 3, 2025 03:55
@dgading dgading merged commit de53ee6 into CivicActions:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgading dgading dgading approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acabouet @dgading