Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGOV-554: Githook pre-commit config #60

Merged
merged 19 commits into from
Feb 4, 2025

Conversation

acabouet
Copy link
Collaborator

@acabouet acabouet commented Feb 3, 2025

No description provided.

@acabouet acabouet force-pushed the PGOV-554-husky-and-githooks-AC branch from 919c722 to a68ed25 Compare February 3, 2025 21:24
@grugnog grugnog self-requested a review February 4, 2025 00:42
Copy link
Member

@grugnog grugnog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this all out (by adding some bad Drupal & JS code) and it was all detected. I pushed a couple of minor changes to the bash script so that it runs both linters and errors if either fails.
We should remind folks to run composer install after this is merged, so that they get the new hook installed.

@acabouet acabouet requested a review from vauxia February 4, 2025 02:57
@acabouet acabouet changed the title PGOV-554: Husky and Githook pre-commit config PGOV-554: Githook pre-commit config Feb 4, 2025
@acabouet acabouet merged commit 1e5c363 into CivicActions:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants