-
Notifications
You must be signed in to change notification settings - Fork 25
Oauth #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Oauth #721
Conversation
|
Changes for enabling Facebook and Google login. There is also a video included with the demo of functionality. |
|
Thank you for implementing social login. It works as expected in the happy path. However, I have a few concerns regarding its impact on the existing functionality and overall security:
Please address these issues before merging, and let us ensure we do not compromise existing users or production stability while introducing new features. @delhilad - If you are unable to take it up due to your existing commitments we can transfer this PR to the existing team. Please let me know. |
Security_Problem.mp4Hi Please find the video for the security problem because of allowing an app_anonymous user to set the session token. Auth cookie should be set when you are verifying the jwt token. |
Describe the technical changes contained in this PR
This will enable the login using the facebook and Google Oauth token, for the pre-approved email records.
Previous behaviour
Before this change, user could login using their email and password to login.
New behaviour
User will no longer be able to login using the usename and password, now they will need an email id linked to their Google or Facebook login to login to the webapp. The email linked to their social media account will be already registered to enable their account. First they will verify the email id to be used for the login, and then they will provide authentication token using the linked social media(Google or Facebook) account.
Related issues addressed by this PR
List issue numbers using the "Fixes #xxx" syntax
Have the following been addressed?