호가 0원이슈 임시 해결 #139
Merged
호가 0원이슈 임시 해결 #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
체결보다 호가 갱신이 먼저 일어나도록 수정했습니다. 이 또한, 나중에 비동기적 방식이 다시 도입될 경우 문제가 발생할 수 있기 때문에 추가 수정 예정입니다.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
Contributor
|
근데 궁금한 게 제가 PR 올리면 SonarQube Code Analysis 부분에서 fail 뜨는데 여기서는 success 뜨네요?? |
Contributor
Author
|
소나큐브에 나오는 메시지 보면 수정코드중 new line이 많지 않은 경우 coverage와 관련된 quality체크를 무시하는거 같네요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 작업내용
🐞 이슈사항