-
Notifications
You must be signed in to change notification settings - Fork 2
Feat/realitybot #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/realitybot #148
Conversation
caniro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스케줄링 로직 수정 고생하셨습니다!
소중한 테스트들이..ㅠㅠ
src/main/java/com/cleanengine/coin/realitybot/config/SchedulerConfig.java
Outdated
Show resolved
Hide resolved
Junh-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정내용 확인했습니다
저도 문제 내용을 처음 들었을 때 Order를 수정하는 방식을 먼저 떠올렸었는데, 초기 scheduling 설정과 unitprice의 설정은 밀접한 관련이 있으니, 이렇게 한쪽에서 호출하는 방식으로 구현하신것이 더 괜찮게 보이네요.
감사합니다 또 h2환경에선 똑같은 문제가 발생해서 둘이 빌드되는 과정에서 뭐가 다른지 이참에 학습해봐야겠어요 |

✨ 작업내용
🐞 이슈사항