Develop #30
Merged
Develop #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
์ฌ์ด๋๋ฐ๋ฅผ ์ด๋ฉด ์คํฌ๋กค์ด ์๊ธฐ๋ ๋ฌธ์ ๋ฅผ ์์ ํ์์ต๋๋ค.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ์์ฝ(Summary)
rendering์ blockingํ๋ react-toastify์ css์ ์ํฌํธ๋ฅผ ๋น๋๊ธฐ์ ์ผ๋ก ๊ฐ์ ธ์ค๋๋ก ์์ ํ์์ต๋๋ค.
๋ฉ์ธํ์ด์ง์ ํฐํธ๋ฅผ preloadํ์์ต๋๋ค.
๐ ๏ธ PR ์ ํ
์ด๋ค ๋ณ๊ฒฝ ์ฌํญ์ด ์๋์?
๐ฌ ๊ณต์ ์ฌํญ to ๋ฆฌ๋ทฐ์ด
ex) ๋ฉ์๋ XXX์ ์ด๋ฆ์ ๋ ์ ์ง๊ณ ์ถ์๋ฐ ํน์ ์ข์ ๋ช ์นญ์ด ์์๊น์?
๐ธ์คํฌ๋ฆฐ์ท (์ ํ)
## โ PR Checklist PR์ด ๋ค์ ์๊ตฌ ์ฌํญ์ ์ถฉ์กฑํ๋์ง ํ์ธํ์ธ์.
Closes #28, #29